Remove SearchWithIndexBlocksIT (replaced by ITs in Serverless) #132013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benchaplin
added
>non-issue
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
v9.2.0
serverless-linked
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #131662, #131693, #131695, #131698.
In order to create these tests, I had to manually mutate cluster state using
setState. This approach was unreliable (~1% fail rate)—sometimes other cluster state updates would occur in the middle of my update loop leading to inconsistent states.I've given up on manually setting the block and opted for higher-level ITs in stateless where the block is added as it would be added in prod: when an index is new and search shards are not ready.