Fix InboundDecoderTests.testDecodePreHeaderSizeVariableInt()
#132215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test needed to be updated when elastic#123390 was backported to 8.19 in elastic#123554 since the test didn't exist on main when elastic#123390 was merged.
JeremyDahlgren
added
>test
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
reviewed
Jul 31, 2025
Comment on lines
164
to
165
| final Object body = fragments.get(1); | ||
| assertThat(body, instanceOf(ReleasableBytesReference.class)); |
There was a problem hiding this comment.
Do we really need to lose these assertions, or is it just the .close() call below that causes the issue?
There was a problem hiding this comment.
Just the close(), I restored the assertion.
DaveCTurner
approved these changes
Aug 1, 2025
This was referenced Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test needed to be updated when #123390 was backported to 8.19 in #123554 since the test didn't exist on main when #123390 was merged. Note that CI had failures for this test in #123554.
Closes: #132203, #132281