Remove legacy log4j-1.2 dependencies completely #132238
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
dakrone
added
:Core/Infra/Logging
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
@elasticmachine test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Analysis
After upgrading to Log4j 2.25.1 in #132166, the module dependency
requires org.apache.log4j(from Log4j 1.2 era) causes boot failure:java.lang.module.FindException: Module org.apache.log4j not found, required by org.elasticsearch.securityThis legacy dependency has no actual code references in the codebase (verified by full-text search). Retaining it would:
Solution
Completely remove the obsolete dependency declaration from:
x-pack/plugin/security/src/main/java/module-info.javaValidation
org.apache.log4jin codebasemainbranch (Log4j 1.2 present)Critical Note
This is a prerequisite for #132166. Merging this first will unblock the Log4j upgrade.