Skip to content

Skip update/100_synthetic_source tests in yamlRestCompatTests #132296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jordan-powers
Copy link
Contributor

The yamlRestCompatTest is running the 8.18 version of the test against the main build, with a special header to enable compatibility mode with the 8.x rest api (see REST_API_COMPATIBILITY.md). However, this old version of the test is expecting the disk_usage api to report the presence of a test.fields._recovery_source field, which no longer exists since the introduction of synthetic recovery source.

This patch just disables the yamlRestCompatTests check for these tests.

Resolves #132110
Resolves #132108

@jordan-powers jordan-powers self-assigned this Jul 31, 2025
@jordan-powers jordan-powers added auto-backport Automatically create backport pull requests when merged Team:StorageEngine :StorageEngine/Mapping The storage related side of mappings v9.2.0 v9.1.1 v8.19.1 labels Jul 31, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@jordan-powers jordan-powers added the >test Issues or PRs that are addressing/adding tests label Jul 31, 2025
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jordan-powers jordan-powers enabled auto-merge (squash) August 1, 2025 23:07
@jordan-powers jordan-powers merged commit 7d2de6b into elastic:main Aug 4, 2025
33 checks passed
@jordan-powers jordan-powers deleted the skip-rest-compat-synthetic-source-tests branch August 4, 2025 23:42
@jordan-powers jordan-powers restored the skip-rest-compat-synthetic-source-tests branch August 4, 2025 23:42
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.1 Commit could not be cherrypicked due to conflicts
8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 132296

@jordan-powers
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
9.1
9.0
8.19

Questions ?

Please refer to the Backport tool documentation

jordan-powers added a commit to jordan-powers/elasticsearch that referenced this pull request Aug 5, 2025
…c#132296)

(cherry picked from commit 7d2de6b)

# Conflicts:
#	muted-tests.yml
jordan-powers added a commit to jordan-powers/elasticsearch that referenced this pull request Aug 5, 2025
…c#132296)

(cherry picked from commit 7d2de6b)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Aug 5, 2025
… (#132425)

(cherry picked from commit 7d2de6b)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Aug 5, 2025
… (#132427)

(cherry picked from commit 7d2de6b)

# Conflicts:
#	muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Aug 5, 2025
… (#132426)

(cherry picked from commit 7d2de6b)

# Conflicts:
#	muted-tests.yml
szybia added a commit to szybia/elasticsearch that referenced this pull request Aug 5, 2025
…cking

* upstream/main: (26 commits)
  [Fleet] add privileges to `kibana_system` to read integrations data (elastic#132400)
  Add `TestEntitlementsRule` with support for dynamic entitled node paths for testing (elastic#132077)
  Reduce logging frequency for GCS per project clients (elastic#132429)
  Skip update/100_synthetic_source tests in yamlRestCompatTests (elastic#132296)
  Correct exception for missing nested path (elastic#132408)
  Fixing esql release tests elastic#132369 (elastic#132406)
  Adjust date docvalue formatting to return 4xx instead of 5xx (elastic#132414)
  Handle nested fields with the termvectors REST API in artificial docs (elastic#92568)
  Only collect bulk scored vectors when exceeding min competitive (elastic#132293)
  Fix release tests diskbbq update (elastic#132405)
  ESQL: Fix skipping of generative tests (elastic#132390)
  Short circuit failure handling in OIDC flow (elastic#130618)
  Small optimization in OptimizedScalarQuantizer by using mul instead of div (elastic#132397)
  Aggs: Add validation to Bucket script pipeline agg (elastic#132320)
  ESQL: Multiple parameters in ungrouped aggs (elastic#132375)
  ESQL: Explain test operators (elastic#132374)
  EQL: Deal with internally created IN in a different way for EQL (elastic#132167)
  Speed up hierarchical k-means by computing distances in bulk (elastic#132384)
  Reduce the number of fields per document (elastic#132322)
  Assert current thread in ESQL (elastic#132324)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine >test Issues or PRs that are addressing/adding tests v8.19.1 v9.0.5 v9.1.1 v9.2.0
Projects
None yet
3 participants