Add 'branch' option #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly needed for protected branches. If you want to push the diagram to a separate branch, you can pass the branch option. The script will check if that branch exists and push the diagram there or create the branch and push the diagram!
|
this is great, thanks! Made some tiny tweaks: update a variable name, added a log when creating a new branch, and added the param to the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on a project that has protected branches. I thought it would be a cool idea to be able to push to a separate branch, so I've added a
branchparameter.If you pass the branch param, the script will check if that branch exists and push the diagram there or create the branch and push the diagram.
As future improvements, maybe extracting this functionality to separate functions will be helpful.
Also, an
ssh-keyoption could be useful for pushing to potentially protected branches, although that's a bit sketchy.