-
Notifications
You must be signed in to change notification settings - Fork 18.3k
cmd/go: invalidate test cache when -coverpkg sources change #74773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
cmd/go: invalidate test cache when -coverpkg sources change #74773
Conversation
This PR (HEAD: bb12492) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/690775. |
Message from Jorropo: Patch Set 1: Commit-Queue+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/690775. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-07-29T11:16:25Z","revision":"7c78557e0f55c0fbd57694af257866cdad171575"} Please don’t reply on this GitHub thread. Visit golang.org/cl/690775. |
Message from Jorropo: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/690775. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/690775. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/690775. |
When using -coverpkg, test caching could return stale coverage data if covered packages were modified but the test package itself was unchanged. This occurred because the test cache only considered the test package's dependencies, not the broader set of packages specified by -coverpkg. This change adds dependency tracking for covered packages and includes their source file hashes in cache validation. When any file in a covered package changes, the test cache is properly invalidated, ensuring fresh coverage data is generated. Fixes issue where coverage reports contained duplicate entries with different line ranges after source modifications in covered packages. Fixes golang#74873
bb12492
to
f7cd72d
Compare
This PR (HEAD: f7cd72d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775. Important tips:
|
Message from Ryan Currah: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/690775. |
When using -coverpkg, test caching could return stale coverage data
if covered packages were modified but the test package itself was
unchanged. This occurred because the test cache only considered the
test package's dependencies, not the broader set of packages specified
by -coverpkg.
This change adds dependency tracking for covered packages and includes
their source file hashes in cache validation. When any file in a
covered package changes, the test cache is properly invalidated,
ensuring fresh coverage data is generated.
Fixes issue where coverage reports contained duplicate entries with
different line ranges after source modifications in covered packages.
Fixes #74873