UNet2DConditionModel
: add support for QK Normalization by propagating qk_norm
value from config through to child attention modules
#12051
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12050
QK Normalization was already implemented in
Attention
__init__
, but adding eg"qk_norm": "rms_norm"
to the config.json for aUNet2DConfitionModel
had no effect.This PR makes config
qk_norm
have an effect by propagating its value through the variousUNet2DConfitionModel
block initialization logic.Without this PR:
With this PR:
(I have successfully finetuned a model after making this change)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Pings based on
git blame
:@yiyixuxu @gnobitab @sayakpaul