fixed bug in defining embed dim for UNet1D #12111
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12110
Hi! First time contributor to diffusers, apologies for anything I'm doing wrong in the PR. I noticed what I believe is a very simple and small bug in creating 1D UNets. A value is hardcoded that should not be. I noticed this while trying to debug why my UNet kept giving me shape errors. I just transitioned from using a 2d model to 1d for my personal use case, and this was causing me a headache! I am basically solving my own "Good First Issue" (linked above) noticed during my usage. I believe the Issue itself explains the problem and solution pretty straightforwardly.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
Tagging @sayakpaul @yiyixuxu @DN6