Skip to content

chore(deps): update @stencil/core to v4.36.2 #30587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025
Merged

chore(deps): update @stencil/core to v4.36.2 #30587

merged 2 commits into from
Jul 31, 2025

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jul 31, 2025

Issue number: resolves #30565


What is the current behavior?

Stencil is on v4.33.1

What is the new behavior?

  • Updates Stencil to v4.36.2
  • Updates children references to __children in reorder-group

Does this introduce a breaking change?

  • Yes
  • No

Other information

I searched through the repository for other components that may be affected but did not find any.

Dev build: 8.7.1-dev.11753971948.1b297d94
Reorder Example using dev build: StackBlitz
Router Example using dev build: StackBlitz

Copy link

vercel bot commented Jul 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 2:19pm

@brandyscarney brandyscarney marked this pull request as ready for review July 31, 2025 14:19
@brandyscarney brandyscarney requested a review from a team as a code owner July 31, 2025 14:19
@brandyscarney brandyscarney requested a review from ShaneK July 31, 2025 14:19
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Mildly worried about the any declarations on el.__children but not sure what to do better there at the moment.

@ShaneK
Copy link
Member

ShaneK commented Jul 31, 2025

Also I was curious why this didn't impact split-pane. I can't see anything bad happening there, but I guess I'm not sure why exactly this happened in the first place

@brandyscarney
Copy link
Member Author

Looks good to me. Mildly worried about the any declarations on el.__children but not sure what to do better there at the moment.

Those were there prior to my change so I left it alone.

Also I was curious why this didn't impact split-pane. I can't see anything bad happening there, but I guess I'm not sure why exactly this happened in the first place

Split pane is a shadow component and this only needs to be applied to non-shadow components.

@brandyscarney brandyscarney added this pull request to the merge queue Jul 31, 2025
Merged via the queue into main with commit 6203b88 Jul 31, 2025
65 checks passed
@brandyscarney brandyscarney deleted the FW-6714 branch July 31, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Cannot add property 0, object is not extensible on Ionic Vue + Android 11
2 participants