Skip to content

test(core): fix flaky datetime and input-otp tests #30598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 4, 2025

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Aug 4, 2025

This fixes the flaky/failing tests here:

should not have visual regressions with a custom styled calendar
CleanShot 2025-08-04 at 13 46 12@2x

should switch the calendar header when moving to a month with a different number of days
CleanShot 2025-08-04 at 13 45 33@2x

You can run them locally using:

  • npm run test.e2e.docker src/components/datetime/test/datetime.e2e.ts -- --repeat-each=10
  • npm run test.e2e.docker src/components/datetime/test/custom/datetime.e2e.ts -- --repeat-each=10

Copy link

vercel bot commented Aug 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2025 9:15pm

@github-actions github-actions bot added the package: core @ionic/core package label Aug 4, 2025
@brandyscarney brandyscarney marked this pull request as ready for review August 4, 2025 17:47
@brandyscarney brandyscarney requested a review from a team as a code owner August 4, 2025 17:47
@brandyscarney brandyscarney requested a review from ShaneK August 4, 2025 17:47
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patience++

@brandyscarney brandyscarney added this pull request to the merge queue Aug 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 4, 2025
@brandyscarney brandyscarney removed this pull request from the merge queue due to a manual request Aug 4, 2025
@brandyscarney brandyscarney changed the title test(datetime): fix flaky tests test(core): fix flaky datetime and input-otp tests Aug 4, 2025
@brandyscarney brandyscarney enabled auto-merge August 4, 2025 21:12
@brandyscarney brandyscarney added this pull request to the merge queue Aug 4, 2025
Merged via the queue into main with commit 56265e3 Aug 4, 2025
52 checks passed
@brandyscarney brandyscarney deleted the test/fix-flaky-datetime branch August 4, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants