Skip to content

Implemented @ignore #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Implemented @ignore #13

wants to merge 5 commits into from

Conversation

dancrumb
Copy link

First documentation pull request; if you'd rather I did this another way, let me know

@hegemonic
Copy link
Contributor

Thanks for submitting this pull request! I haven't had a chance to review it yet, and I'm about to head out of town for a bit, so this may sit idle for a few days. Rest assured that it is greatly appreciated nonetheless. :)

@dancrumb
Copy link
Author

dancrumb commented Feb 1, 2013

No worries... and be as critical as you like; I'm happy to make
improvements as needed

On Fri, Feb 1, 2013 at 12:24 AM, Jeff Williams notifications@github.comwrote:

Thanks for submitting this pull request! I haven't had a chance to review
it yet, and I'm about to head out of town for a bit, so this may sit idle
for a few days. Rest assured that it is greatly appreciated nonetheless. :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/13#issuecomment-12982467.

@micmath
Copy link
Contributor

micmath commented Feb 1, 2013

I can have a look at this over the weekend, if you're not around, Jeff.

Michael

On 1 Feb 2013, at 06:24, Jeff Williams notifications@github.com wrote:

Thanks for submitting this pull request! I haven't had a chance to review it yet, and I'm about to head out of town for a bit, so this may sit idle for a few days. Rest assured that it is greatly appreciated nonetheless. :)


Reply to this email directly or view it on GitHub.

@hegemonic
Copy link
Contributor

@micmath, have at it!

@hegemonic
Copy link
Contributor

Well, this never did get reviewed. 😐

The @inner tag already got documentation in another commit.

I reviewed the proposed docs for @ignore and @license, which were taken from the JsDoc Toolkit 2 documentation, and felt that they needed to be revised. I rewrote the docs and committed them in f18ec01.

Those changes make the pull request obsolete, so I'm closing it.

@hegemonic hegemonic closed this Dec 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants