Limit the size of content on very large screens #198
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Zearin would you like to give me some feedback? |
Zearin
reviewed
Jan 22, 2020
| <img alt="Creative Commons License" class="license-badge" src="images/cc-by-sa.svg" | ||
| width="80" height="15" /></a> | ||
| <br> | ||
| Copyright © 2011-2019 the |
There was a problem hiding this comment.
I'm not sure about that. On my opinion that change will be another topic (pull request) completely different. 😉
|
(Sorry it took me so long to respond!) Looks okay to me. If there are further tweaks, they can happen in future Pull Requests. If you’ve tested it on screens that big (which I don’t have at home, so I’ll just trust you), I say it’s worth a merge. |
Yes I tried on a double monitor (extended desktop). |
|
@hegemonic ping! ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some media queries to limit the size of content on very large screens.
I'm not a CSS expert so I would like to get feedback from other users about these changes.