Skip to content

add have_all_attributes_in #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

mkamensky
Copy link

Added another matcher to check that all attributes are included in the given list

@stas
Copy link
Collaborator

stas commented Jan 17, 2020

@mkamensky could you please help us understand how is this different from the have_attributes matcher?

@stas stas added the question label Jan 17, 2020
@mkamensky
Copy link
Author

@mkamensky could you please help us understand how is this different from the have_attributes matcher?

As far as I understand, have_attributes checks that all given attributes exist. This one checks that there are no other attributes included (my use case authorization, I want to make sure that only the permitted attributes are returned).

@stas
Copy link
Collaborator

stas commented Jan 20, 2020

@mkamensky I don't think we should introduce a new matcher. Let's use the existing one and extend it's functionality using a parameter/chained call. If that's ok with you and you want to submit a PR, I'll be happy to take a look. Alternatively, I'll be looking into #4 and will review this one along with it.

@stas stas mentioned this pull request Jan 21, 2020
3 tasks
@stas
Copy link
Collaborator

stas commented Feb 15, 2020

Superseded by #14

@stas stas closed this Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants