Skip to content

Improved failure message and description for have_attribute matcher #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2020
Merged

Improved failure message and description for have_attribute matcher #24

merged 1 commit into from
Jul 24, 2020

Conversation

lukemelia
Copy link
Contributor

What is the current behavior?

image

What is the new behavior?

image

Checklist

Please make sure the following requirements are complete:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes /
    features)- not applicable
  • All automated checks pass (CI/CD)

@stas stas merged commit 7107928 into jsonapi-rb:master Jul 24, 2020
@stas
Copy link
Collaborator

stas commented Jul 24, 2020

Thanks a lot Luke! 🤩

@lukemelia lukemelia deleted the enhancement/have-attribute-failure branch July 25, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukemelia @stas