Check has_attribute instead of actual #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check if attribute key exists instead of checking if attribute value exists, addresses case of attribute value being nil
|
Thank you @alexbeeken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check if attribute key exists instead of checking if attribute value exists, addresses case of attribute value being nil
What is the current behavior?
If the key is present in the attributes hash but the value of it is nil it will show a test failure message of this:
which is clearly incorrect as the key is present in the array
What is the new behavior?
It will now show the correct error message of a nil value when expecting a different value
more helpful error message
Checklist
Please make sure the following requirements are complete:
features)