-
-
Notifications
You must be signed in to change notification settings - Fork 8k
{,Range}Slider: accept callable valfmt arguments #30362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is fundamentally reasonable. I would make the range callable two parameters rather than a sequence. |
41ba77f
to
8791358
Compare
Done! But it will take me a day to reach the docs updating and release notes etc. |
Converted to a draft to reflect that. |
8791358
to
17eb374
Compare
All docs related changes needed are ready for review. |
17eb374
to
b1ca2a5
Compare
10569c3
to
2e45041
Compare
Indeed my phrasings aren't always concise :) It's OK. Thanks for the review, fixed them all. |
0caff5c
to
41ad716
Compare
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
41ad716
to
e715a5a
Compare
Done :). |
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
0557c76
to
b6d7441
Compare
PR summary
I wanted to create a slider for an "order of magnitude" parameter, that scales logarithmic, but prints concisely the number in the
valfmt
parameter.Somewhat based on the idea here:
Example:
I'd like to get feedback before writing examples to documentation.
PR checklist
Slider
&RangeSlider
classes.