Update Node.js core modules #62201
Open
Update Node.js core modules #62201
+17
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
reviewed
Aug 5, 2025
| @@ -3518,7 +3486,7 @@ ts.JsTyping.discoverTypings:: | |||
| "enable": true | |||
| }, | |||
| "unresolvedImports": [ | |||
| "node:zlib", | |||
| "node:quic", | |||
There was a problem hiding this comment.
I was very confused why everything in this list got changed until I realized it's because one module was removed and one was added, so the diff makes it look like the code shifted
jakebailey
reviewed
Aug 5, 2025
| @@ -1330,38 +1330,6 @@ TI:: [hh:mm:ss:mss] Finished typings discovery: | |||
| ] | |||
| } | |||
|
|
|||
| ts.JsTyping.discoverTypings:: | |||
There was a problem hiding this comment.
This entire log was removed; is the test testing something that was removed and needs to be updated?
There was a problem hiding this comment.
It's due to a removed "unqualified" module from the list (test/mock_loader), which was an internal module that was previously populated onto the public list, so there's one less resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronises some upstream changes to builtin modules.