Fix string and undefined in tobytes() #130
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 74.86% 74.84% -0.02%
==========================================
Files 39 39
Lines 4726 4727 +1
Branches 967 968 +1
==========================================
Hits 3538 3538
Misses 839 839
- Partials 349 350 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
titaiwangms
force-pushed
the
titaiwang/support_string_tobytes
branch
from
43eea17 to
0f3f91a
Compare
justinchuby
reviewed
Jul 19, 2025
|
Is tobytes() well defined for STRING? I wonder why we would see array[None]? Is it valid? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STRING and UNDEFINED are not supported by itemsize.
NOTE: STRING shows up when array[None] appears (UNDEFINED is added only for consistency.)