Create the convenience methods i() and o() on Node
#34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage 74.86% 74.86%
=======================================
Files 39 39
Lines 4726 4730 +4
Branches 967 967
=======================================
+ Hits 3538 3541 +3
- Misses 839 840 +1
Partials 349 349 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://app.smartcontext.ai/default/https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
force-pushed
the
justinchu/i-o
branch
from
65016d4 to
86e7054
Compare
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
xadupre
reviewed
Jun 3, 2025
src/onnx_ir/_core.py
Outdated
| def i(self, index: int = 0) -> Value | None: | ||
| """Get the input value at the given index. | ||
|
|
||
| This is a convenience method that is equivalent to `self.inputs[index]`. |
There was a problem hiding this comment.
Can you add the new syntax self.inputs[index] can be replaced by?
There was a problem hiding this comment.
Added docstring. Does that look good to you?
titaiwangms
reviewed
Jun 3, 2025
|
|
||
| The following is equivalent:: | ||
|
|
||
| node.outputs[0] == node.o(0) == node.o() # Default index is 0 |
There was a problem hiding this comment.
I feel it's duplicated.
There was a problem hiding this comment.
Ok. I will release 0.1.1 without this for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i()ando()convenience methods toNodefor accessing input and output values by index, respectively.