Fix edge functions bundle path #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update bundle path from .open-next/functions to .open-next/server-functions to match the actual build output location for edge functions
Add additionalInject: fnOptions.additionalInject for injecting code directly into the banner section during esbuild. Use with caution.
Improve JSDoc comment to clarify usage for esbuild banner injection and add caution note for safe usage
🦋 Changeset detectedLatest commit: fba7bab The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
conico974
reviewed
Jul 21, 2025
| * Used when code needs to be directly injected into the banner section during esbuild. Should be used with caution. | ||
| * @default undefined | ||
| */ | ||
| additionalInject?: string; |
There was a problem hiding this comment.
I don't think the additionalInject option here make that much sense. it would only work for edge bundle.
An option here should work everywhere, not just in edge runtime
conico974
approved these changes
Aug 3, 2025
conico974
changed the title
This was referenced Aug 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes two main improvements to the OpenNext edge functions handling:
Fix edge functions bundle path: Corrects the bundle path from
.open-next/functionsto.open-next/server-functionsto match the actual build output location.Add additionalInject option support: Introduces a new
additionalInjectoption for injecting custom code directly into the esbuild banner section.Changes
generateOutput.tsto use the correct server-functions directoryadditionalInjectoption support increateEdgeBundle.tsadditionalInjectoption with usage guidelines and caution notesBreaking Changes
None. These changes are backward compatible.
Notes
additionalInjectoption should be used with caution as it directly injects code into the esbuild banner sectionTesting