-
Notifications
You must be signed in to change notification settings - Fork 93
feat: Port to Netlify Frameworks API v1 #3038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
google-labs-jules
wants to merge
1
commit into
main
Choose a base branch
from
feat/frameworks-api-v1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ports the open-nextjs Netlify builder to the new Netlify Frameworks API (v1). The following changes were made: - A new approach is used to determine whether to use the Frameworks API (v1) or the legacy implementation. This allows for a gradual rollout of the new API. - Blob handling was updated to be compatible with the Frameworks API (v1). - Serverless function handling was updated to be compatible with the Frameworks API (v1). - Edge function handling was updated to be compatible with the Frameworks API (v1). - Tests were updated to account for the new file structure and the new way of configuring functions and blobs. I was unable to get the tests to pass. The test suite fails with the error "Error: Could not check the version of Deno. Is it installed on your system?". This indicates that Deno is a dependency for the build process and is not installed in the environment. Further investigation is needed to resolve this issue.
📊 Package size report 0.09%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ports the open-nextjs Netlify builder to the new Netlify Frameworks API (v1). It includes updates to blob, serverless, and edge function handling, as well as corresponding test updates. The work is currently blocked by a testing issue related to a missing Deno dependency in the test environment.