Added ENV for autovacuum_vacuum_scale_factor and autovacuum_analyze_scale_factor #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miggets7
force-pushed
the
feature/auto_full_vacuum
branch
from
0ba4bb8 to
98e0202
Compare
richturner
requested changes
Jun 25, 2025
|
I ran the current commit locally and with Please confirm functionality locally both with existing storage volume and without. |
richturner
requested changes
Jun 25, 2025
scripts/vacuum_full.sh
Outdated
Comment on lines
3
to
4
| # Log file for vacuum operations | ||
| LOG_FILE="/var/lib/postgresql/vacuum_full.log" |
scripts/start_cron.sh
Outdated
Comment on lines
6
to
7
| # Check if VACUUM FULL schedule is set | ||
| if [ -n "${OR_VACUUM_FULL_CRON_SCHEDULE}" ]; then |
There was a problem hiding this comment.
Keep this outer if in the entrypoint for ease of reading
|
Additional tasks:
|
Removed alpine dockerfile as it became obsolete because of timescaledb arm64 support
Miggets7
changed the title
richturner
requested changes
Jul 14, 2025
Comment on lines
+1
to
+19
| #!/bin/bash | ||
| set -e | ||
|
|
||
| echo "-------------------------------------------------------------------------------------" | ||
| echo "Setting autovacuum parameters during initialization..." | ||
| echo "-------------------------------------------------------------------------------------" | ||
|
|
||
| # Set vacuum parameters | ||
| psql -v ON_ERROR_STOP=1 --username "$POSTGRES_USER" --dbname "$POSTGRES_DB" <<-EOSQL | ||
| ALTER SYSTEM SET autovacuum_vacuum_scale_factor = $OR_AUTOVACUUM_VACUUM_SCALE_FACTOR; | ||
| ALTER SYSTEM SET autovacuum_analyze_scale_factor = $OR_AUTOVACUUM_ANALYZE_SCALE_FACTOR; | ||
| SELECT pg_reload_conf(); | ||
| EOSQL | ||
|
|
||
| echo "-----------------------------------------------------------------------------------" | ||
| echo "Autovacuum parameters set: " | ||
| echo " - autovacuum_vacuum_scale_factor = $OR_AUTOVACUUM_VACUUM_SCALE_FACTOR" | ||
| echo " - autovacuum_analyze_scale_factor = $OR_AUTOVACUUM_ANALYZE_SCALE_FACTOR" | ||
| echo "-----------------------------------------------------------------------------------" |
There was a problem hiding this comment.
Looking at this now I don't see value in having this init script and the logic in the entrypoint, the entrypoint logic should be sufficient I think
| # Extract current setting if it exists (commented or uncommented) | ||
| CURRENT_AUTOVAC_SETTING=$(grep -E "^[#]*autovacuum_vacuum_scale_factor" "$PGDATA/postgresql.conf" | grep -oE "[0-9]\.[0-9]+" || echo "") | ||
|
|
||
| if [ -z "$CURRENT_AUTOVAC_SETTING" ] || [ "$CURRENT_AUTOVAC_SETTING" != "$OR_AUTOVACUUM_VACUUM_SCALE_FACTOR" ]; then |
There was a problem hiding this comment.
Check OR_AUTOVACUUM_VACUUM_SCALE_FACTOR is set if not then leave this setting alone (just in case DBA has configured this manually)
| # Extract current setting if it exists (commented or uncommented) | ||
| CURRENT_AUTOVAC_ANALYZE_SETTING=$(grep -E "^[#]*autovacuum_analyze_scale_factor" "$PGDATA/postgresql.conf" | grep -oE "[0-9]\.[0-9]+" || echo "") | ||
|
|
||
| if [ -z "$CURRENT_AUTOVAC_ANALYZE_SETTING" ] || [ "$CURRENT_AUTOVAC_ANALYZE_SETTING" != "$OR_AUTOVACUUM_ANALYZE_SCALE_FACTOR" ]; then |
There was a problem hiding this comment.
Check OR_AUTOVACUUM_VACUUM_SCALE_FACTOR is set if not then leave this setting alone (just in case DBA has configured this manually)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.