fix: startup all resource indexing #2881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
This reverts commit faf9bdf.
csviri
changed the title
This was referenced Jul 31, 2025
xstefank
approved these changes
Jul 31, 2025
.../java/io/javaoperatorsdk/operator/baseapi/startsecondaryaccess/StartupSecondaryAccessIT.java
Show resolved
Hide resolved
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
xstefank
approved these changes
Jul 31, 2025
csviri
changed the title
csviri
changed the title
csviri
changed the title
metacosm
reviewed
Aug 5, 2025
| * Used to initialize resources when the namespace is generated but the operator is not started | ||
| * yet. | ||
| */ | ||
| public Builder withBeforeStartHook(Consumer<LocallyRunOperatorExtension> beforeStartHook) { |
There was a problem hiding this comment.
Might need a "before-shutdown" hook as well to perform clean-up if needed.
There was a problem hiding this comment.
That is usually not needed strictly , since one can clean the resources at the end of the test, so functionally that is doable. But agree that might be a nicer api.
metacosm
reviewed
Aug 5, 2025
| SECONDARY_NUMBER); | ||
|
|
||
| if (secondary.size() != cached.size()) { | ||
| secondaryAndCacheSameAmount = false; |
There was a problem hiding this comment.
why not simply:
secondaryAndCacheSameAmount = secondary.size() == cache.size();There was a problem hiding this comment.
That would not work if later is the same value would overwrite the false, so here the aim is that if once false therefore always false
metacosm
reviewed
Aug 5, 2025
| @@ -44,6 +44,22 @@ void dependentResourceCanReferenceEachOther() { | |||
| assertThat(operator.get(Secret.class, TEST_RESOURCE_NAME + i)).isNotNull(); | |||
| } | |||
| }); | |||
|
|
|||
| for (int i = 0; i < EXECUTION_NUMBER; i++) { | |||
There was a problem hiding this comment.
Yeah, this test was failing with a different version of the fix, and improved it while investigating, I can make it as a separate PR.
metacosm
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indexes all the resources in the cache on startup, making sure that all resources are on the index for first reconiliation.