Skip to content

Configuration Support for registry+v1 bundle (w/ Helm aware) #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bentito
Copy link
Contributor

@bentito bentito commented Aug 1, 2025

WIP

See RFC for what this is trying to do:
See https://docs.google.com/document/d/1rmcT8tXcezjq0Iy3Cde097Y8ZaCgUXhEgiuyfv1vXUI

kubectl create namespace demo-ns
# to just see the values rendered into the ConfigMap

go run cmd/demo-config/main.go testdata/images/bundles/test-operator/v2.0.0 demo-ns 

# or to apply them live in kind cluster
make run
go run cmd/demo-config/main.go testdata/images/bundles/test-operator/v2.0.0 demo-ns  kubectl apply -f -
kubectl -n demo-ns get configmap test-configmap -o yaml

# to see what helm might be like, helm chart added to the test-operator v2 
# and so you can do (with helm flag you can point at bundle will use the supplied chart anyway:
go run cmd/demo-config/main.go --helm testdata/images/bundles/test-operator/v2.0.0 helm-ns

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

bentito added 4 commits July 30, 2025 16:09
Signed-off-by: Brett Tofel <btofel@redhat.com>
Signed-off-by: Brett Tofel <btofel@redhat.com>
Signed-off-by: Brett Tofel <btofel@redhat.com>
Signed-off-by: Brett Tofel <btofel@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2025
Copy link

netlify bot commented Aug 1, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 1bccb45
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6890fd21a82f490008fbd658
😎 Deploy Preview https://deploy-preview-2132--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

openshift-ci bot commented Aug 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tmshort for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bentito bentito added this to OLM v1 Aug 1, 2025
@bentito bentito moved this to Designing in OLM v1 Aug 1, 2025
Signed-off-by: Brett Tofel <btofel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
Status: Designing
Development

Successfully merging this pull request may close these issues.

2 participants