Skip to content

Fix ISO_LABEL handling and symlink resolution in ISO detection #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025
Merged

Fix ISO_LABEL handling and symlink resolution in ISO detection #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions oracle-linux-image-tools/bin/build-image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,10 +367,9 @@ stage_kickstart() {
image_create() {
common::echo_header "Install Oracle Linux"

# retrieve disk label -- alternatively: isoinfo -d -i
local ISO_LABEL
# shellcheck disable=SC2034,SC2153
ISO_LABEL=$(file "${ISO_PATH}" | sed -e "s/.* '\(.*\)' .*/\1/" -e 's/ /\\x20/g')
# retrieve disk label
# shellcheck disable=SC2034
ISO_LABEL="${ISO_LABEL:-$(file -L "${ISO_PATH}" | sed -e "s/.* '\(.*\)' .*/\1/" -e 's/ /\\x20/g')}"

declare -ga virt_install_args
# Set Serial console
Expand Down