Upgrade boost to 1.88.0 #8641
Draft
Upgrade boost to 1.88.0 #8641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksykulev
commented
Jul 7, 2025
| @@ -37,6 +37,8 @@ function(boostMain) | |||
| thirdparty_boost_uuid | |||
| thirdparty_boost_scope_exit | |||
| thirdparty_boost_circular_buffer | |||
| thirdparty_boost_describe | |||
| thirdparty_boost_scope | |||
There was a problem hiding this comment.
Linking errors due to missing headers.
ksykulev
commented
Jul 7, 2025
| @@ -532,8 +546,11 @@ function(generateBoostThread) | |||
| BOOST_THREAD_BUILD_LIB=1 | |||
| ) | |||
|
|
|||
| # Add all boost library include paths for cross-library dependencies | |||
| file(GLOB boost_lib_dirs "${BOOST_ROOT}/libs/*/include") | |||
There was a problem hiding this comment.
boost 1.88.0 uses b2 to create the unified headers, getting around this by including everything.
ksykulev
commented
Jul 7, 2025
| else() | ||
| set_property(SOURCE "${library_root}/src/fcontext.cpp" PROPERTY COMPILE_FLAGS "-std=c++17") | ||
| endif() | ||
| endif() |
There was a problem hiding this comment.
Not finding the standard library? 🤔
There was a problem hiding this comment.
I wonder if this is fixed by #8640
@lucasmrod
ksykulev
force-pushed
the
upgrade-boost
branch
11 times, most recently
from
25dbe6a to
59be982
Compare
ksykulev
force-pushed
the
upgrade-boost
branch
2 times, most recently
from
52ebebc to
eb5880c
Compare
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8593
CONTRIBUTING.mdguide at the root of the repo.format_checktarget.If it is not, then move the committed files to the git staging area,
build the
formattarget to format them, and then re-commit.More information is available on the wiki.