Various return types and values consolidation #19418
Merged
+32
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Category: Engine
Extension: standard
SAPI: phpdbg
ABI break
labels
alexandre-daubois
force-pushed
the
cons-return-type-val
branch
from
3aee5cb to
25fb75a
Compare
Girgias
reviewed
Aug 8, 2025
ext/standard/image.c
Outdated
Comment on lines
1207
to
1216
| bool php_is_image_avif(php_stream* stream) { | ||
| bool php_is_image_avif(php_stream* stream) { /* {{{ php_is_image_avif */ | ||
| struct php_avif_stream avif_stream; | ||
| avif_stream.stream = stream; | ||
|
|
||
| if (AvifInfoIdentifyStream(&avif_stream, php_avif_stream_read, php_avif_stream_skip) == kAvifInfoOk) { | ||
| return 1; | ||
| return true; | ||
| } | ||
| return 0; | ||
| return false; | ||
| } | ||
| /* }}} */ |
There was a problem hiding this comment.
I would remove the {{{ marker all together if touching the function, and you can simplify this by just doing:
return AvifInfoIdentifyStream(&avif_stream, php_avif_stream_read, php_avif_stream_skip) == kAvifInfoOk;There was a problem hiding this comment.
Ah yes of course 👍
alexandre-daubois
force-pushed
the
cons-return-type-val
branch
from
25fb75a to
c0f6e35
Compare
Girgias
approved these changes
Aug 12, 2025
|
Probably makes sense to fix this in bulk with Coccinelle. See torvalds/linux@46b5c9b as an example. |
|
Having a look. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.