Skip to content

Fix for PGPRO-2440 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2019
Merged

Fix for PGPRO-2440 #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7f4aab
Don't create empty HTAB in package, if it is not necessary
CherkashinSergey Feb 21, 2019
7b866ea
Optimize objects removal in subtransaction commit
CherkashinSergey Feb 25, 2019
6117f17
Optimize objects removal in subtransaction rollback
CherkashinSergey Feb 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions expected/pg_variables_trans.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1794,7 +1794,8 @@ SELECT package FROM pgv_stats() ORDER BY package;
package
---------
vars
(1 row)
vars2
(2 rows)

SELECT * FROM pgv_list() ORDER BY package, name;
package | name | is_transactional
Expand Down Expand Up @@ -1878,9 +1879,9 @@ SELECT pgv_remove('vars', 'any1');

RELEASE comm;
SELECT pgv_get('vars', 'any1',NULL::text);
ERROR: unrecognized package "vars"
ERROR: unrecognized variable "any1"
COMMIT;
-- Test for PGPRO-2440
-- Tests for PGPRO-2440
SELECT pgv_insert('vars3', 'r3', row(1 :: integer, NULL::varchar), true);
pgv_insert
------------
Expand Down Expand Up @@ -1908,6 +1909,32 @@ SELECT pgv_delete('vars3', 'r3', 3);
t
(1 row)

BEGIN;
SELECT pgv_set('vars1', 't1', ''::text);
pgv_set
---------

(1 row)

SELECT pgv_set('vars2', 't2', ''::text, true);
pgv_set
---------

(1 row)

SAVEPOINT sp1;
SAVEPOINT sp2;
SELECT pgv_free();
pgv_free
----------

(1 row)

ERROR;
ERROR: syntax error at or near "ERROR"
LINE 1: ERROR;
^
COMMIT;
SELECT pgv_free();
pgv_free
----------
Expand Down
Loading