Fix package removal in rollback #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
za-arthur
reviewed
Mar 7, 2019
| if (!dlist_is_empty(changesStack)) | ||
| if (dlist_is_empty(changesStack)) | ||
| { | ||
| removeObject(object, type); |
There was a problem hiding this comment.
Можешь добавить тест на этот код?
Подробности смотри https://codecov.io/gh/postgrespro/pg_variables/commit/38de97e243262dcca9683864a3f6f1e42efe7edd
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
=========================================
+ Coverage 95.64% 95.7% +0.05%
=========================================
Files 4 4
Lines 896 908 +12
=========================================
+ Hits 857 869 +12
Misses 39 39
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Исправил поведение пакета при rollback-е.