create a proper Logfire type
#87
Merged
+942
−770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -72,7 +73,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| .run() | |||
| .await?; | |||
|
|
|||
| shutdown_handler.shutdown()?; | |||
| // Shutdown handled automatically by the guard | |||
|
|
||
| /// Builder for logfire configuration, returned from [`logfire::configure()`][crate::configure]. | ||
| #[derive(Default)] | ||
| #[must_use = "call `.finish()` to complete logfire configuration."] |
friendlymatthew
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the result of calling
logfire::configure().finish()to produce aLogfirestruct.The on-drop-shutdown semantics are moved to a
ShutdownGuardtype, which is accessible by callinglogfire.shutdown_guard()on aLogfirestruct.I think this cleans up the public API and makes it possible to be deliberate about where to install the guard. The previous
ShutdownHandlertype was doing too many things.As part of this cleanup I've moved a lot of code out of
lib.rsand into eitherconfig.rsor a newlogfire.rsfile.