Fix calling Stored Procedure with kwargs #65
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…depended on the variable 'argc' which was not declared. This declares the variable, and updates the handling of current_word in the loop to handle instances where the number of items in kw is less than the number of arguments the stored procedure requires.
|
Wow. Keyword handling was obviously missing some tests. I'll commit this once I get around to testing it. |
|
Speaking of tests, could you add some to your patch? |
|
I will. I noticed an issue with my patch, so I'll fix that and write some tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with calling a StoredProcedure with kwargs. The for loop depended on the variable 'argc' which was not declared. This declares the variable, and updates the handling of current_word in the loop to handle instances where the number of items in kw is less than the number of arguments the stored procedure requires.