enable older ipaddr module, for compatibility with older versions of python #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…python Python only added the ipaddress module to its standard library in 3.3, but some older systems will still be using older versions of python3 for some time. (e.g. debian wheezy, which will probably be supported into 2016, has python 3.1). For these older systems, the simplest route is to install the ipaddr module, which has slightly different naming schemes for some functions. For systems already running python 3.3, this patch won't change their behavior, but it will make it possible to run py-postgresql against python 3.1, as long as the external ipaddr module is also installed separately.
|
I think it would be wiser to just make a backport of the ipaddress module from Python3.3. Guarantees a consistent interface moving forward to Python3.3 in the future. If you're not actually using the IP address structure, you can also cast the ip or cidr columns to strings in the query. No dependency needed in that case. |
|
Actually, such a backport already exists: https://pypi.python.org/pypi/ipaddress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python only added the ipaddress module to its standard library in
3.3, but some older systems will still be using older versions of
python3 for some time. (e.g. debian wheezy, which will probably be
supported into 2016, has python 3.1).
For these older systems, the simplest route is to install the ipaddr
module, which has slightly different naming schemes for some
functions.
For systems already running python 3.3, this patch won't change their
behavior, but it will make it possible to run py-postgresql against
python 3.1, as long as the external ipaddr module is also installed
separately.