[mypyc] feat: optimize C code for str.count #19582
Draft
+8
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh. Not sure if this will work as I intended. I thought the builder was able to automagically handle the conversion to py_ssize_t. Will leave open for a few days in the hopes that somebody might have a useful pointer here. Then will either finish or close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking over these C functions I added in #19264 I realized we're doing a conversion for no real reason, and it is better to let mypyc's builder decide whether or not a conversion is necessary. It might be the case that we already have a py_ssize_t value(s) available to pass directly into the C-API function.