-
Notifications
You must be signed in to change notification settings - Fork 637
Add ability to pass model_dir to .ci/scripts/test_huggingface_optimum #13116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13116
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New Failures, 1 Cancelled Job, 1 Unrelated FailureAs of commit 3846a62 with merge base 7750116 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
@@ -270,6 +270,7 @@ def test_vit(model_id, model_dir, recipe, *, quantize=False, run_only=False): | |||
parser.add_argument("--model", type=str, required=True) | |||
parser.add_argument("--recipe", type=str, required=True) | |||
parser.add_argument("--quantize", action="store_true", help="Enable quantization") | |||
parser.add_argument("--model_dir", type=str, required=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit add help?
recipe=args.recipe, | ||
quantize=args.quantize, | ||
run_only=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does this depend on the model_dir
type
test_fn( | ||
model_id=model_id, | ||
model_dir=tmp_dir, | ||
recipe=args.recipe, | ||
quantize=args.quantize, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
de-dup across if/else
Adds ability to specify model_dir to optimum test script. This is convinient if you want the pte file for local debugging. If no model_dir is specified, a temp directory is created.