Consistently use ptsToSeconds #784
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #764, this PR updates various methods in SingleStreamDecoder.cpp to use
ptsToSeconds
when performing calculations with thetime_base
.Additionally,
ptsToSeconds
is updated to useav_q2d
to ensure theAVRational
s are correctly handled.Tests are updated as well to reflect the added precision:
ptsSeconds
are updated fromEXPECT_EQ
toEXPECT_DOUBLE_EQ
.pytest.approx
is used to comparepts_seconds
.