Skip to content

Add node version check #7723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2025
Merged

Add node version check #7723

merged 2 commits into from
Jul 26, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jul 25, 2025

Errors on determining the bin path using dynamic import may actually be due to a node version that is too old.
Report the correct error for that case.

Copy link

pkg-pr-new bot commented Jul 25, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7723

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7723

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7723

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7723

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7723

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7723

commit: 7475336

@cknitt cknitt requested a review from zth July 25, 2025 19:14
@cknitt cknitt force-pushed the check-node-version branch 2 times, most recently from dfa7c22 to 3ee0746 Compare July 25, 2025 19:24
@cknitt cknitt requested a review from fhammerschmidt July 25, 2025 19:25
@cknitt cknitt force-pushed the check-node-version branch from 3ee0746 to 7475336 Compare July 26, 2025 08:25
@cknitt cknitt merged commit 1fac9fa into master Jul 26, 2025
27 checks passed
@cknitt cknitt deleted the check-node-version branch July 26, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants