Skip to content

bump bootstrap compiler to 1.90 beta #144997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

bump bootstrap compiler to 1.90 beta #144997

wants to merge 4 commits into from
+719 −731

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Aug 6, 2025

There were significantly less cfg(bootstrap) and cfg(not(bootstrap)) this release. Presumably due to the fact that we change the bootstrap stage orderings to reduce the need for them and it was successful 🙏

@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Aug 6, 2025
@BoxyUwU
Copy link
Member Author

BoxyUwU commented Aug 6, 2025

r? release

@rustbot rustbot assigned pietroalbini and unassigned thomcc Aug 6, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jieyouxu
jieyouxu reviewed Aug 6, 2025
View reviewed changes
@Mark-Simulacrum
Copy link
Member

r=me with the one comment fixed

@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Aug 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2025

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Aug 6, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@BoxyUwU
Copy link
Member Author

BoxyUwU commented Aug 6, 2025

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Aug 6, 2025

📌 Commit 7bc3462 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2025
@fmease fmease mentioned this pull request Aug 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol left review comments

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@pietroalbini pietroalbini

Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@BoxyUwU @rustbot @rust-log-analyzer @Mark-Simulacrum @bors @Kobzol @jieyouxu @thomcc @pietroalbini