Rollup of 12 pull requests #145003
Merged
Rollup of 12 pull requests #145003
+260
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tshepang Mbambo <hopsi@tuta.io>
Currently the Args new function is scope constrained to pub(super) but this stops me from being able to construct Args structs in unit tests.
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
The current `rust-version = "1.63"` was inherited from rayon, but it doesn't make sense to limit this in the compiler workspace. Having any setting at all has effects on tools like `cargo info` that try to infer the MSRV when the workspace itself doesn't specify it. Since we are the compiler, our only MSRV is whatever bootstrapping requires.
libs-api has agreed to rename these functions to `isolate_highest_one`/`isolate_lowest_one`
This fixes a few intrinsic docs that had a link directly to itself instead of to the correct function in the `mem` module.
This makes it possible to bless the snapshot files used by `diff()` in newly-created run-make tests, without having to create the files manually beforehand.
…=jieyouxu Rehome 33 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` rust-lang#143902 divided into smaller, easier to review chunks. Part of rust-lang#133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer Inspired by the methodology that ``@Kivooeo`` was using. r? ``@jieyouxu``
…oxyUwU Add documentation for unstable_feature_bound There is more detail and explanation in https://hackmd.io/``````@tiif/Byd3mq7Ige`````` Original PR that implemented this: rust-lang#140399 r? ``````@BoxyUwU`````` to nominate for types team discussion
Change visibility of Args new function Currently the Args new function is constrained to pub(super) but this stops me from being able to construct Args structs in unit tests. This pull request is to change this to pub.
… r=fee1-dead Add regression tests for seemingly fixed issues Closes rust-lang#104314 Closes rust-lang#125866
…=fmease [rustdoc] Fix wrong `i` tooltip icon Current wrong display: <img width="334" height="37" alt="Screenshot From 2025-08-04 17-42-38" src="https://github.com/user-attachments/assets/57046475-6162-487f-998f-ebb2434c111d" /> With the fix: <img width="334" height="37" alt="image" src="https://github.com/user-attachments/assets/e761a103-dc39-4e30-8c8e-cfc7fab52fde" /> r? ``@fmease``
…ctives-hint, r=clubby789 compiletest: add hint for when a ui test produces no errors
…iper Correct the use of `must_use` on btree::IterMut I'm working on stricter target checking for attributes and found this one
Drop `rust-version` from `rustc_thread_pool` The current `rust-version = "1.63"` was inherited from rayon, but it doesn't make sense to limit this in the compiler workspace. Having any setting at all has effects on tools like `cargo info` that try to infer the MSRV when the workspace itself doesn't specify it. Since we are the compiler, our only MSRV is whatever bootstrapping requires.
…eLapkin Autolabel PRs that change explicit tail call tests as `F-explicit_tail_calls` mrrrow~
run-make: Allow blessing snapshot files that don't exist yet This makes it possible to bless the snapshot files used by `diff()` in newly-created run-make tests, without having to create the files manually beforehand. r? jieyouxu
…htriplett num: Rename `isolate_most_least_significant_one` functions Tracking issue - rust-lang#136909 libs-api has agreed to rename these unstable functions to `isolate_highest_one`/`isolate_lowest_one` rust-lang#136909 (comment) `isolate_most_significant_one` -> `isolate_highest_one` `isolate_least_significant_one` -> `isolate_lowest_one`
Fix some doc links for intrinsics This fixes a few intrinsic docs that had a link directly to itself instead of to the correct function in the `mem` module.
rustbot
added
A-compiletest
rustbot
added
A-testsuite
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
Since we potentially have time before it hits the top of the queue, I'd like to check this which has bitten several of us recently with an unknown origin, on rollup which included some PR on this list: @bors2 try jobs=test-various |
rust-bors bot
added a commit
that referenced
this pull request
Aug 6, 2025
Rollup of 12 pull requests try-job: test-various
|
Also watch out for #144995 (comment), which gives so little information that I have not been able to attribute it to any particular PR. |
Yes, I had tried to find out what went wrong too and failed. |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 8fb40f7 (parent) -> 29cdc6a (this PR) Test differencesShow 284 test diffsStage 1
Stage 2
(and 86 additional test diffs) Additionally, 98 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 29cdc6a109ee98a382f974bf89d3971b4385399c --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: 8fb40f798a In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Aug 6, 2025
|
Finished benchmarking commit (29cdc6a): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 6.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 464.179s -> 464.98s (0.17%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
tests/ui/issues/tests to other subdirectories undertests/ui/#144552 (Rehome 33tests/ui/issues/tests to other subdirectories undertests/ui/)itooltip icon #144913 ([rustdoc] Fix wrongitooltip icon)must_useon btree::IterMut #144926 (Correct the use ofmust_useon btree::IterMut)rust-versionfromrustc_thread_pool#144928 (Droprust-versionfromrustc_thread_pool)F-explicit_tail_calls#144945 (Autolabel PRs that change explicit tail call tests asF-explicit_tail_calls)isolate_most_least_significant_onefunctions #144971 (num: Renameisolate_most_least_significant_onefunctions)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup