Skip to content

Couple of minor cleanups #145004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Couple of minor cleanups #145004

wants to merge 3 commits into from
+51 −83

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Aug 6, 2025

No description provided.

bjorn3 added 3 commits August 6, 2025 14:13
@bjorn3
Include allocator module in LLVM_passes timer
2472d19
@bjorn3
Remove unused field from ModuleConfig
ee38bc0
@bjorn3
Remove bitcode_llvm_cmdline
6fbea4f 
It used to be necessary on Apple platforms to ship with the App Store,
but XCode 15 has stopped embedding LLVM bitcode and the App Store no
longer accepts apps with bitcode embedded.
@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

These commits modify compiler targets.
(See the Target Tier Policy.)

@WaffleLapkin
Copy link
Member

r=me with green ci
r? WaffleLapkin

@rustbot rustbot assigned WaffleLapkin and unassigned petrochenkov Aug 6, 2025
@bjorn3
Copy link
Member Author

bjorn3 commented Aug 6, 2025

@bors r=WaffleLapkin

@bors
Copy link
Collaborator

bors commented Aug 6, 2025

📌 Commit 6fbea4f has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2025
@bjorn3
Copy link
Member Author

bjorn3 commented Aug 6, 2025

cc #117364 which removed embedding of LLVM bitcode on Apple platforms.

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 7, 2025
@Zalathar
Rollup merge of rust-lang#145004 - bjorn3:remove_unused_fields, r=Waf…
dad85cf 
…fleLapkin

Couple of minor cleanups
@Zalathar Zalathar mentioned this pull request Aug 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bjorn3 @rustbot @WaffleLapkin @bors @petrochenkov