Fix rustdoc scrape examples crash #145008
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
A-run-make
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
commented
Aug 6, 2025
| @@ -0,0 +1,7 @@ | |||
| pub struct X; | |||
There was a problem hiding this comment.
Btw, tester.rs must exist, without it, it doesn't crash.
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
fix-rustdoc-scrape-examples-crash
branch
from
d29e4f3 to
ff371fe
Compare
This comment has been minimized.
This comment has been minimized.
fmease
approved these changes
Aug 6, 2025
|
Eh, r=me once CI green |
GuillaumeGomez
force-pushed
the
fix-rustdoc-scrape-examples-crash
branch
from
ff371fe to
a2b1714
Compare
|
|
Thank you! We really appreciate it. |
|
@bors r=fmease rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 6, 2025
…examples-crash, r=fmease Fix rustdoc scrape examples crash Fixes rust-lang#144752. The regression was introduced in rust-lang#144600. Although I don't understand why it is an issue currently, this allows to bypass the failure for now until we can figure out what's wrong as it's currently blocking new `bevy`'s release. cc `@alice-i-cecile` r? `@fmease`
bors
added a commit
that referenced
this pull request
Aug 6, 2025
Rollup of 15 pull requests Successful merges: - #144195 (Parser: Recover from attributes applied to types and generic args) - #144794 (Port `#[coroutine]` to the new attribute system) - #144835 (Anonymize binders in tail call sig) - #144861 (Stabilize `panic_payload_as_str` feature) - #144917 (Enforce tail call type is related to body return type in borrowck) - #144948 (we only merge candidates for trait and normalizes-to goals) - #144956 (Gate const trait syntax) - #144970 (rustdoc: fix caching of intra-doc links on reexports) - #144972 (add code example showing that file_prefix treats dotfiles as the name of a file, not an extension) - #144975 (`File::set_times`: Update documentation and example to support setting timestamps on directories) - #144977 (Fortify generic param default checks) - #144996 (simplifycfg: Mark as changed when start is modified in collapse goto chain) - #144998 (mir: Do not modify NonUse in `super_projection_elem`) - #145000 (Remove unneeded `stage` parameter when setting up stdlib Cargo) - #145008 (Fix rustdoc scrape examples crash) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144752.
The regression was introduced in #144600. Although I don't understand why it is an issue currently, this allows to bypass the failure for now until we can figure out what's wrong as it's currently blocking new
bevy's release.cc @alice-i-cecile
r? @fmease