-
Notifications
You must be signed in to change notification settings - Fork 12
test: migrate from unittest to pytest, add VCR, and set up nightly test workflow #1169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
strategy: | ||
fail-fast: false | ||
matrix: | ||
python: ["3.9", "3.11", "3.13"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should follow https://devguide.python.org/versions/#supported-versions
SCW_SECRET_KEY: ${{ secrets.SCW_SECRET_KEY }} | ||
SCW_DEFAULT_ORGANIZATION_ID: ${{ secrets.SCW_DEFAULT_ORGANIZATION_ID }} | ||
SCW_DEFAULT_PROJECT_ID: ${{ secrets.SCW_DEFAULT_PROJECT_ID }} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there notification in case something breaks like with terraform and the CLI ?
import vcr | ||
import inspect | ||
|
||
from vcr.cassette import CassetteContextDecorator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this imported?
|
||
|
||
@scw_vcr.use_cassette("test_vpc_list_all.yaml") | ||
def test_vpc_list_all(vpc_api): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to infer the cassette name from the name of the test called? It seems cumbersome to repeat the name of the test in a file name.
No description provided.