fix: add support for named param type $name
#475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteinroe
changed the title
$name
| match self.first() { | ||
| '$' => { | ||
| self.bump(); | ||
| break self.dollar_quoted_string(start); |
There was a problem hiding this comment.
Suggested change
| break self.dollar_quoted_string(start); | |
| return self.dollar_quoted_string(start); |
There was a problem hiding this comment.
hat mich kurz irritiert, weil der breaked value ja auch aus der obrigen fn returned wird
| start.push(c); | ||
| } | ||
| _ => { | ||
| break TokenKind::NamedParam { |
There was a problem hiding this comment.
Suggested change
| break TokenKind::NamedParam { | |
| return TokenKind::NamedParam { |
There was a problem hiding this comment.
this would actually behave differently. we need break, and the value is then returned from the loop. with return, we would return the value from the function.
juleswritescode
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
closes #474
from #454 (comment)