Add RFC5425 length field #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a format to pick framing the message with an RFC 5425 length field. The RFC doesn't specify a maximum length, but does suggest 8192; added a digit over that to make sure systemd-netlogd is not the limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
LogFormatto pick framing the message with an RFC 5425 length field. The RFC doesn't specify a maximum length, but does suggest 8192; added a digit over that to make sure systemd-netlogd is not the limit. This is an alternative to the newline framing, and can also be used over plain TCP (non-TLS), e.g., RFC 6587.This isn't full RFC 5425 support as this patch doesn't add support for client certificates.
PS: I extended the
SysLogTransmissionLogFormattable the way you currently have it, which uses powers-of-two like a bit mask (as if you could set multiple of them). I didn't actually see it used like that in the code though, so I'm not sure why it andSysLogTransmissionProtocolare done that way. I think that's wasting some space in in thelog_format_tableandprotocol_table(currently an insignificant amount, but doubling each new flag) but otherwise doesn't matter.