Fix callable type mapping to be Closure mapping #753
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite accidentally I discovered a bug with my implementation: if a value that is also a callable is returned from a field, it will get wrapped in a
Deferred
wrapper and be called as a callable, instead of simply being returned as a value.E.g.:
If you then run the
test { title }
query, instead of simply returning the{"title": "test"}
, it would call thetest
function - becauseis_callable('test')
returnstrue
.Potential fixes
This could be solved two ways:
callable
, only leave support for actualClosure
callable
, but make it so it wraps values inDeferred
based on whether the type was specified as callable, not if the value itself is callableThis PR implements option #1. Option #2 would require some architectural changes to how GraphQLite works, way outside the scope of this feature :)