-
-
Notifications
You must be signed in to change notification settings - Fork 117
merge dev to main (v2.17.1) #2200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis change updates the JetBrains IDE package version and changelog, upgrades Prisma dependencies in CLI plugin integration tests, and removes an unused private method from the EnhancerGenerator class in the schema enhancer plugin. No changes to exported or public entities were made. Changes
Estimated code review effort2 (10–30 minutes) Possibly related PRs
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/ide/jetbrains/CHANGELOG.md (1)
7-12
: Changelog/version mismatchYou introduced a new
2.16.0
section but the build script is already at2.17.1
.
Either:
- Rename this section to
2.17.1
, or- Bump
build.gradle.kts
back to2.16.0
.Keeping them in lock-step avoids confusion for consumers.
tests/integration/tests/cli/plugins.test.ts (2)
78-78
: Non-deterministic wildcard version
'@prisma/client@6.12.x'
may pull future 6.12 patch releases with behavioral changes.
Consider pinning to the exact patch version used in CI (e.g.,6.12.0
) or using lockfiles to guarantee reproducibility.
88-88
: Keep dev-dependency alignedGood to see
prisma@6.12.x
matching the runtime client. Same wildcard caveat applies here; pinning would make local & CI outcomes identical.packages/schema/src/plugins/enhancer/enhance/index.ts (1)
2-2
: Stale helper left behind
invariant
was removed, butfindAuxProps()
(defined later) is now unused after droppingtransformVariableStatementProps
.
Delete the unused helper to keep the file lean and avoid future confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (20)
package.json
is excluded by!**/*.json
packages/ide/jetbrains/package.json
is excluded by!**/*.json
packages/language/package.json
is excluded by!**/*.json
packages/misc/redwood/package.json
is excluded by!**/*.json
packages/plugins/openapi/package.json
is excluded by!**/*.json
packages/plugins/swr/package.json
is excluded by!**/*.json
packages/plugins/tanstack-query/package.json
is excluded by!**/*.json
packages/plugins/trpc/package.json
is excluded by!**/*.json
packages/plugins/trpc/tests/projects/nuxt-trpc-v10/package.json
is excluded by!**/*.json
packages/plugins/trpc/tests/projects/nuxt-trpc-v11/package.json
is excluded by!**/*.json
packages/plugins/trpc/tests/projects/t3-trpc-v11/package.json
is excluded by!**/*.json
packages/runtime/package.json
is excluded by!**/*.json
packages/schema/package.json
is excluded by!**/*.json
packages/sdk/package.json
is excluded by!**/*.json
packages/server/package.json
is excluded by!**/*.json
packages/testtools/package.json
is excluded by!**/*.json
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
,!**/*.yaml
tests/integration/test-run/package.json
is excluded by!**/*.json
tests/integration/tests/frameworks/nextjs/test-project/package.json
is excluded by!**/*.json
tests/integration/tests/frameworks/trpc/test-project/package.json
is excluded by!**/*.json
📒 Files selected for processing (4)
packages/ide/jetbrains/CHANGELOG.md
(1 hunks)packages/ide/jetbrains/build.gradle.kts
(1 hunks)packages/schema/src/plugins/enhancer/enhance/index.ts
(1 hunks)tests/integration/tests/cli/plugins.test.ts
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: OSSAR-Scan
- GitHub Check: build-test (20.x)
- GitHub Check: build-test (20.x)
- GitHub Check: dependency-review
🔇 Additional comments (1)
packages/ide/jetbrains/build.gradle.kts (1)
12-12
: Version bump but no matching changelog entry
version = "2.17.1"
is fine, but the companion CHANGELOG only goes up to2.16.0
.
Add a## 2.17.1
section (or move the fix now shown under Unreleased) to keep release artifacts in sync.
No description provided.