-
Notifications
You must be signed in to change notification settings - Fork 970
Edit pass on new "Troubleshoot template instantiation impact on build time" topic #5552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit pass on new "Troubleshoot template instantiation impact on build time" topic #5552
Conversation
…ct on build time" topic
…ot template instantiation impact on build time" topic
…te instantiation impact on build time" topic
…tiation impact on build time" topic
@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit ecb27fe: ✅ Validation status: passed
For more details, please refer to the build report. |
PRMerger Results
|
Curious, what's the point of the "This PR contains edit pass in the title." check? |
@Rageking8 - "Edit pass" is a term used by some editing teams that have exemptions for PR review which is why PRMerger flags the term. @TylerMSFT - Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for catching my filename changes. I changed the example mid-article and didn't catch all the changes.
#sign-off |
Best reviewed commit-by-commit.
SmallValue.cpp
as this topic usesTemplateAnalysis.cpp
instead (unlike in the blog Templates View for Build Insights in Visual Studio).[!NOTE]
, and add trailing newline at the end of the topic.