Skip to content

Edit pass on new "Troubleshoot template instantiation impact on build time" topic #5552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Rageking8
Copy link
Contributor

Best reviewed commit-by-commit.

  • Remove erroneous mentions of SmallValue.cpp as this topic uses TemplateAnalysis.cpp instead (unlike in the blog Templates View for Build Insights in Visual Studio).
  • Fix a typo of the build time in an image description ("4.066 seconds" -> "4.966 seconds").
  • Trim all trailing spaces, remove superfluous semicolons, format code snippets, use caps for [!NOTE], and add trailing newline at the end of the topic.

Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit ecb27fe:

✅ Validation status: passed

File Status Preview URL Details
docs/build-insights/tutorials/build-insights-template-view.md ✅Succeeded

For more details, please refer to the build report.

Copy link
Contributor

PRMerger Results

Issue Description
Edit Pass In Title This PR contains edit pass in the title.
File Change Percent This PR contains file(s) with more than 30% file change.

@Rageking8
Copy link
Contributor Author

PRMerger Results

Issue Description
Edit Pass In Title This PR contains edit pass in the title.
File Change Percent This PR contains file(s) with more than 30% file change.

Curious, what's the point of the "This PR contains edit pass in the title." check?

@v-regandowner
Copy link
Contributor

@Rageking8 - "Edit pass" is a term used by some editing teams that have exemptions for PR review which is why PRMerger flags the term.


@TylerMSFT - Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Jul 18, 2025
Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching my filename changes. I changed the example mid-article and didn't catch all the changes.

@TylerMSFT
Copy link
Collaborator

#sign-off

@Court72 Court72 merged commit 21903da into MicrosoftDocs:main Jul 18, 2025
2 checks passed
@Rageking8 Rageking8 deleted the edit-pass-on-new-build-insights-template-view-topic branch July 19, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants