Skip to content

Add nemo data desginer intro notebooks #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

johnnygreco
Copy link

This PR adds intro tutorial notebooks for NeMo Data Designer, a new NeMo microservice that is about to go into into EA.

Signed-off-by: Johnny Greco <jogreco@nvidia.com>
Signed-off-by: Johnny Greco <jogreco@nvidia.com>
@shashank3959
Copy link
Collaborator

LGTM, please replace any staging references to actual release links.

Copy link

@mikeknep mikeknep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM one tiny nit

readme = "README.md"
requires-python = ">=3.9"

dependencies = [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we technically pick it up transitively through nemo-microservices, but we should add pydantic here since we import and use it explicitly.

@johnnygreco
Copy link
Author

LGTM, please replace any staging references to actual release links.

@shashank3959 – I think we are go now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants