libexpr: fix various overflows and type mismatches (backport #13309) #13614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I found wrong casts of
NixInt
values, which can cause crashes of current Nix versions because ofsizeof(unsigned int) < sizeof(NixInt::Inner)
, e.g.Furthermore usually
sizeof(unsigned int) < sizeof(size_t)
on 64 bit systems, which becomes problematic when a list contains more than2^32
values and this case isn't impossible. Thussize_t
is used as index type.Context
Includes tests for cases, where
NixInt::Inner
was incorrectly casted.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.
This is an automatic backport of pull request #13309 done by [Mergify](https://mergify.com).