-
Notifications
You must be signed in to change notification settings - Fork 517
Debug: add pathMappings option #5254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -581,6 +581,24 @@ | |||||||
| "type": "string", | ||||||||
| "description": "If you would like to use a custom coreclr attach debug launch configuration for the debug session, specify the name here. Otherwise a default basic config will be used. The config must be a coreclr attach config. Launch configs are not supported.", | ||||||||
| "default": false | ||||||||
| }, | ||||||||
| "pathMappings": { | ||||||||
| "type": "array", | ||||||||
| "description": "Optional: An array of path mappings to use when debugging a remote PowerShell host process. Each mapping is an object with 'localRoot' and 'remoteRoot' properties. This is only used if the current integrated terminal is connected to a remote PowerShell runspace.", | ||||||||
| "items": { | ||||||||
| "type": "object", | ||||||||
| "properties": { | ||||||||
| "localRoot": { | ||||||||
| "type": "string", | ||||||||
| "description": "The local root to map." | ||||||||
| }, | ||||||||
| "remoteRoot": { | ||||||||
| "type": "string", | ||||||||
| "description": "The remote root to map." | ||||||||
| } | ||||||||
| } | ||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The pathMappings schema doesn't specify 'required' properties for the localRoot and remoteRoot fields. Consider adding 'required': ['localRoot', 'remoteRoot'] to ensure both properties are provided when pathMappings are configured.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||||
| }, | ||||||||
| "default": [] | ||||||||
| } | ||||||||
| } | ||||||||
| }, | ||||||||
|
|
@@ -615,6 +633,24 @@ | |||||||
| "type": "boolean", | ||||||||
| "description": "Determines whether a temporary PowerShell Extension Terminal is created for each debugging session, useful for debugging PowerShell classes and binary modules. Overrides the user setting 'powershell.debugging.createTemporaryIntegratedConsole'.", | ||||||||
| "default": false | ||||||||
| }, | ||||||||
| "pathMappings": { | ||||||||
| "type": "array", | ||||||||
| "description": "Optional: An array of path mappings to use when debugging a remote PowerShell host process. Each mapping is an object with 'localRoot' and 'remoteRoot' properties.", | ||||||||
| "items": { | ||||||||
| "type": "object", | ||||||||
| "properties": { | ||||||||
| "localRoot": { | ||||||||
| "type": "string", | ||||||||
| "description": "The local root to map." | ||||||||
| }, | ||||||||
| "remoteRoot": { | ||||||||
| "type": "string", | ||||||||
| "description": "The remote root to map." | ||||||||
| } | ||||||||
| } | ||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The pathMappings schema doesn't specify 'required' properties for the localRoot and remoteRoot fields. Consider adding 'required': ['localRoot', 'remoteRoot'] to ensure both properties are provided when pathMappings are configured.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||||
| }, | ||||||||
| "default": [] | ||||||||
| } | ||||||||
| } | ||||||||
| } | ||||||||
|
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description for the attach configuration includes additional context about remote PowerShell runspace requirements, while the launch configuration description (line 639) omits this important detail. Consider adding consistent context to both descriptions or removing the extra detail from the attach description for consistency.
Copilot uses AI. Check for mistakes.