Skip to content

Add temporaryConsoleWindowActionOnDebugEnd option #5255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add temporaryConsoleWindowActionOnDebugEnd option #5255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aca8ca3
Add temporaryConsoleWindowActionOnDebugEnd option
jborean93 Aug 4, 2025
a17ce7a
Prettier formatting fixes
jborean93 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,21 @@
"type": "string",
"description": "If you would like to use a custom coreclr attach debug launch configuration for the debug session, specify the name here. Otherwise a default basic config will be used. The config must be a coreclr attach config. Launch configs are not supported.",
"default": false
},
"temporaryConsoleWindowActionOnDebugEnd": {
"type": "string",
"description": "Determines whether the temporary PowerShell Extension Terminal is closed when the debugging session ends.",
"default": "keep",
"enum": [
"close",
"hide",
"keep"
],
"enumDescriptions": [
"Closes the temporary PowerShell Extension Terminal when the debugging session ends.",
"Hides the temporary PowerShell Extension Terminal when the debugging session ends and restores the previous window before the debug session had started. This does nothing if the previous window was closed during the debug session.",
"Keeps the temporary PowerShell Extension Terminal open after the debugging session ends."
]
}
}
},
Expand Down Expand Up @@ -615,6 +630,21 @@
"type": "boolean",
"description": "Determines whether a temporary PowerShell Extension Terminal is created for each debugging session, useful for debugging PowerShell classes and binary modules. Overrides the user setting 'powershell.debugging.createTemporaryIntegratedConsole'.",
"default": false
},
"temporaryConsoleWindowActionOnDebugEnd": {
"type": "string",
"description": "Determines whether the temporary PowerShell Extension Terminal is closed when the debugging session ends.",
"default": "keep",
"enum": [
"close",
"hide",
"keep"
],
"enumDescriptions": [
"Closes the temporary PowerShell Extension Terminal when the debugging session ends.",
"Hides the temporary PowerShell Extension Terminal when the debugging session ends and restores the previous window before the debug session had started. This does nothing if the previous window was closed during the debug session.",
"Keeps the temporary PowerShell Extension Terminal open after the debugging session ends."
]
}
}
}
Expand Down
36 changes: 36 additions & 0 deletions src/features/DebugSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,8 @@ export class DebugSessionFeature
return this.resolveAttachDotnetDebugConfiguration(config);
}

config.temporaryConsoleWindowActionOnDebugEnd ??= "keep";

return config;
}

Expand Down Expand Up @@ -498,6 +500,8 @@ export class DebugSessionFeature
session: DebugSession,
): Promise<IEditorServicesSessionDetails | undefined> {
const settings = getSettings();
const previousActiveTerminal = window.activeTerminal;

Comment on lines +503 to +504
Copy link
Preview

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The previousActiveTerminal variable is captured at the start of the function but only used much later in the event handler. Consider moving this declaration closer to where the event handler is defined to improve code readability and reduce the scope of the variable.

Suggested change
const previousActiveTerminal = window.activeTerminal;

Copilot uses AI. Check for mistakes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be captured here as the temp console is created in the next step and takes over the active terminal.

this.tempDebugProcess =
await this.sessionManager.createDebugSessionProcess(
settings,
Expand Down Expand Up @@ -600,6 +604,36 @@ export class DebugSessionFeature
);
}

if (
session.configuration.temporaryConsoleWindowActionOnDebugEnd !==
"keep"
) {
const closeDebugEvent = debug.onDidTerminateDebugSession(
(terminatedSession) => {
closeDebugEvent.dispose();

if (terminatedSession.id !== session.id) {
return;
}

if (
terminatedSession.configuration
.temporaryConsoleWindowActionOnDebugEnd === "close"
) {
this.tempDebugProcess?.dispose();
} else if (
terminatedSession.configuration
.temporaryConsoleWindowActionOnDebugEnd ===
"hide" &&
previousActiveTerminal &&
window.terminals.includes(previousActiveTerminal)
) {
previousActiveTerminal.show();
}
},
);
}

return this.tempSessionDetails;
}

Expand Down Expand Up @@ -705,6 +739,8 @@ export class DebugSessionFeature
}
}

config.temporaryConsoleWindowActionOnDebugEnd ??= "keep";

return config;
}

Expand Down
Loading